[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally

[GitBox]

AlexanderAshitkin commented on code in PR #24:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r970801687


##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -104,9 +106,9 @@ public void execute( List<MojoExecution> mojoExecutions,
                 mojoExecutionRunner.run( mojoExecution );
             }
             cacheState = cacheConfig.initialize();
-            if ( cacheState == INITIALIZED )
+            if ( cacheState == INITIALIZED || skipCacheLookup )
             {
-                result = cacheController.findCachedBuild( session, project, 
mojoExecutions );
+                result = cacheController.findCachedBuild( session, project, 
mojoExecutions, skipCacheLookup );

Review Comment:
   right now cache could be accessed when no initialized it seems. not sure if 
it could cause any issues but in terms of naming and contract clarity it looks 
like cache could be used. `skipCache` should work better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org