[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally

[GitBox]

AlexanderAshitkin commented on code in PR #24:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r970815746


##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -96,6 +97,7 @@ public void execute( List<MojoExecution> mojoExecutions,
         // execute clean bound goals before restoring to not 
interfere/slowdown clean
         CacheState cacheState = DISABLED;
         CacheResult result = CacheResult.empty();
+        boolean skipCacheLookup = cacheConfig.isSkipLookup() || 
MavenProjectInput.shouldSkipCacheLookup( project );

Review Comment:
   regarding the naming - lets call it skipCache. Gradle has similar parameter 
to force rebuild named `--no-build-cache`. from command line and pom 
perspective -DskipBuildCache is more descriptive



##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -96,6 +97,7 @@ public void execute( List<MojoExecution> mojoExecutions,
         // execute clean bound goals before restoring to not 
interfere/slowdown clean
         CacheState cacheState = DISABLED;
         CacheResult result = CacheResult.empty();
+        boolean skipCacheLookup = cacheConfig.isSkipLookup() || 
MavenProjectInput.shouldSkipCacheLookup( project );

Review Comment:
   regarding the naming - lets call it skipCache. Gradle has similar parameter 
to force rebuild named `--no-build-cache`. from command line and pom 
perspective `-DskipBuildCache` is more descriptive



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org