[GitHub] [maven-verifier] michael-o commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

[GitBox]

michael-o commented on code in PR #42:
URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967684642


##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1566,38 +1567,76 @@ public void reset()
         }
     }
 
+    /**
+     * @deprecated will be removed, please use {@link 
#addCliArgument(String)}, {@link #addCliArguments(String...)}
+     */
+    @Deprecated
     public List<String> getCliOptions()

Review Comment:
   I think the comment is partially wrong. You describe one usecase, but the 
other one is really to get the args again, for read-only purposes. That should 
be reflected. For now, we don't need a replacement. (read-only getter)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org