[GitHub] [maven-common-artifact-filters] slawekjaranowski commented on a diff in pull request #31: [MSHARED-1130] Sanitised value nullability in match(Pattern, boolean, String)

[GitBox]

slawekjaranowski commented on code in PR #31:
URL: 
https://github.com/apache/maven-common-artifact-filters/pull/31#discussion_r966310498


##########
src/test/java/org/apache/maven/shared/artifact/filter/AbstractPatternArtifactFilterTest.java:
##########
@@ -579,4 +579,26 @@ public void testmassembly955()
             assertTrue( filter.include( artifact2 ) );
         }
     }
+
+    @Test
+    public void testPartialWildcardShouldNotMatchEmptyComponent()
+    {
+        Artifact artifact = mock( Artifact.class );
+        when( artifact.getGroupId() ).thenReturn( "test-group" );
+        when( artifact.getArtifactId() ).thenReturn( "test-artifact" );
+        when( artifact.getVersion() ).thenReturn( "test-version" );
+        when( artifact.getType() ).thenReturn( null );

Review Comment:
   I restored your first version with mock, all tests use mocks so do it in the 
same way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org