[
https://issues.apache.org/jira/browse/MNG-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597600#comment-17597600
]
ASF GitHub Bot commented on MNG-7529:
-------------------------------------
cstamas commented on code in PR #795:
URL: https://github.com/apache/maven/pull/795#discussion_r958093394
##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##########
@@ -242,6 +231,28 @@ private Versioning readVersions( RepositorySystemSession
session, RequestTrace t
return ( versioning != null ) ? versioning : new Versioning();
}
+ private Versioning filterVersionsByRepositoryType( Versioning versioning,
RemoteRepository remoteRepository )
+ {
+ if ( remoteRepository == null )
+ {
+ return versioning;
+ }
+
+ Versioning filteredVersions = versioning.clone();
+
+ for ( String version : versioning.getVersions() )
+ {
+ boolean snapshotVersion = version != null && version.endsWith(
SNAPSHOT );
Review Comment:
> If I choose to release a `foo-1.0-20220829.222835-1`, this would be a
perfectly legitimate release with a slightly weird but totally legal version.
However, by following your suggestion, this released artifact would be
considered a snapshot and remove from a release repository. So it would not be
considered for a version range. And that is a bug.
Are you sure about this? Am a bit sceptical that Maven itself or some plugin
(enforcer, release, versions...) would NOT handle such a version as snapshot.
Also, in downstream project (the would depend on release
`foo-1.0-20220829.222835-1`) you think the dependency would NOT be handled as
snapshot but as a release (by maven itself or any of the plugins)?
> Maven resolver makes bad repository choices when resolving version ranges
> -------------------------------------------------------------------------
>
> Key: MNG-7529
> URL: https://issues.apache.org/jira/browse/MNG-7529
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 3.8.6
> Reporter: Henning Schmiedehausen
> Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> This is the same problem as MRESOLVER-270. The problem is actually in the
> maven core, not in the resolver. See the description there.
>
> This bug is a placeholder for the fix PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
