[GitHub] [maven-javadoc-plugin] sman-81 commented on a diff in pull request #157: [MJAVADOC-721] Parse stderr output and suppress informational lines

[GitBox]

sman-81 commented on code in PR #157:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/157#discussion_r957335035


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6081,7 +6081,25 @@ && isJavadocVMInitError( output ) )
                 msg.append( exitCode );
                 if ( StringUtils.isNotEmpty( err.getOutput() ) )
                 {
-                    msg.append( " - " ).append( err.getOutput() );
+                    // parse stderr, log informational output, add all other 
to exception message
+                    List<String> nonInfoLines = new ArrayList<>();
+                    for ( String str : err.getOutput().split( "\\R" ) )
+                    {
+                        if ( isInfoOutput( str ) )
+                        {
+                            getLog().debug( str );

Review Comment:
   No, the existing code is just fine in my opinion.
   The informational output of the tool is very verbose. I would therefore log 
at debug level only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org