jorsol commented on code in PR #50:
URL: https://github.com/apache/maven-jar-plugin/pull/50#discussion_r953676232
##########
src/it/MJAR-162/pom.xml:
##########
@@ -32,12 +32,17 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>3.8.1</version>
+ <version>4.13.2</version>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>3.3.0</version>
+ </plugin>
<plugin>
Review Comment:
it's needed as the empty test jar is not filtering the .gitignore file with
the defaults.
Or in other words, the default resource plugin copies the .gitignore into
the jar and the test fails as the jar is not supposed to be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
