[
https://issues.apache.org/jira/browse/MNG-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575849#comment-17575849
]
ASF GitHub Bot commented on MNG-7098:
-------------------------------------
MartinKanters opened a new pull request, #783:
URL: https://github.com/apache/maven/pull/783
This PR ensures that when a multi module project is resumed halfway, the
project progress counter is not reset.
[Related issue](https://issues.apache.org/jira/browse/MNG-7098).
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Project counter should be cumulative when using resume
> ------------------------------------------------------
>
> Key: MNG-7098
> URL: https://issues.apache.org/jira/browse/MNG-7098
> Project: Maven
> Issue Type: Improvement
> Components: Reactor and Workspace
> Reporter: Robert Scholte
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> When doing a resume on a build, the counter now starts again at 1.
> E.g. Suppose a project has 10 modules and the 7th module fails. With a resume
> now you'll see {{[1/4]}}.
> To me it makes more sense to say {{[7/10]}}. You're still as close to the end
> as usual, but this indicates the size of the complete project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
