[
https://issues.apache.org/jira/browse/SCM-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572500#comment-17572500
]
ASF GitHub Bot commented on SCM-992:
------------------------------------
kwin commented on code in PR #159:
URL: https://github.com/apache/maven-scm/pull/159#discussion_r932297184
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java:
##########
@@ -90,28 +95,36 @@ public static void addTarget( Commandline cl, List<File>
files )
}
/**
- *
+ * Use this only for command not requiring environment variables (i.e.
local commands).
Review Comment:
Fixed in
https://github.com/apache/maven-scm/pull/159/commits/1a3cfe51b14204bbef36b48f672af3f72df8a3eb.
> Support explicitly configured SSH private key for gitexe
> --------------------------------------------------------
>
> Key: SCM-992
> URL: https://issues.apache.org/jira/browse/SCM-992
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-provider-gitexe
> Reporter: Konrad Windszus
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> Currently the {{privateKey}} parameter set on
> {{ScmProviderRepositoryWithHost}} is only evaluated in provider "jgit". It
> should also be used for provider "git". Same for {{passphrase}} parameter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
