slawekjaranowski commented on code in PR #113:
URL: https://github.com/apache/maven-shared-utils/pull/113#discussion_r931495170
##########
src/main/java/org/apache/maven/shared/utils/cli/CommandLineUtils.java:
##########
@@ -288,31 +279,13 @@ public Integer call()
errorPumper.setName( "StreamPumper-systemErr" );
errorPumper.start();
- int returnValue;
- if ( timeoutInSeconds <= 0 )
+ if ( timeoutInSeconds > 0 && !p.waitFor( timeoutInSeconds,
TimeUnit.SECONDS ) )
Review Comment:
There is defined `ShutDownHook` lines 237 - 253, and it is also called in
line 362
There are also `pumper` threads which consume all outputs of process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
