[GitHub] [maven-jxr] slawekjaranowski commented on a diff in pull request #62: [JXR-172] Upgrade Parent to 37, project cleanup

[GitBox]

slawekjaranowski commented on code in PR #62:
URL: https://github.com/apache/maven-jxr/pull/62#discussion_r931258066


##########
maven-jxr-plugin/src/it/settings.xml:
##########
@@ -60,18 +46,10 @@ under the License.
             <enabled>true</enabled>
           </snapshots>
         </pluginRepository>
-        <pluginRepository>
-          <id>apache.snapshots</id>
-          <name>Apache Snapshot Repository</name>
-          <url>http://repository.apache.org/content/groups/snapshots/</url>
-          <releases>
-            <enabled>false</enabled>
-          </releases>
-          <snapshots>
-            <enabled>true</enabled>
-          </snapshots>
-        </pluginRepository>        
       </pluginRepositories>
     </profile>
   </profiles>
+  <activeProfiles>
+    <activeProfile>it-repo</activeProfile>
+  </activeProfiles>
 </settings>

Review Comment:
   hehe parent magic 😄 
   
   
https://github.com/apache/maven-parent/blob/550a810a356ca4479717771417cd9dea7b09ed8c/maven-plugins/pom.xml#L235
   
   so MPIR use settings.xml in IT tests 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org