nielsbasjes commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r927364118
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/PropertiesReleaseDescriptorStore.java:
##########
@@ -271,7 +271,7 @@ public void write( BuilderReleaseDescriptor config, File
file )
}
if ( config.getProjectVersionPolicyConfig() != null )
{
- properties.setProperty( "projectVersionPolicyConfig",
config.getProjectVersionPolicyConfig() );
+ properties.setProperty( "projectVersionPolicyConfig",
config.getProjectVersionPolicyConfig().toString() );
Review Comment:
Also: As a consequence of this (i.e. the config can possibly be written to a
file and then read again) I assumed a String config and parse it in the
VersionPolicy.
In the more generic usecase I like this because it leaves the format of the
config fully to the writer of the VersionPolicy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
