[
https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567608#comment-17567608
]
ASF GitHub Bot commented on SCM-945:
------------------------------------
kwin commented on code in PR #153:
URL: https://github.com/apache/maven-scm/pull/153#discussion_r922819148
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java:
##########
@@ -57,6 +58,14 @@
extends AbstractCheckInCommand
implements GitCommand
{
+ private final Map<String, String> environmentVariables;
+
+ public GitCheckInCommand( Map<String, String> environmentVariables )
+ {
+ super();
+ this.environmentVariables = environmentVariables;
+ }
Review Comment:
I didn't consider this API, the only usage is from within
`GitExeScmProvider` and that one only leverages the one with map.
> Support OpenSSH private keys with maven-scm-provider-jgit
> ---------------------------------------------------------
>
> Key: SCM-945
> URL: https://issues.apache.org/jira/browse/SCM-945
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
> Affects Versions: 1.11.2
> Reporter: Konrad Windszus
> Assignee: Michael Osipov
> Priority: Major
>
> For SSH based authentication with private keys in the OpenSSH format the
> following error is being emitted: {{invalid privatekey: ...}}
> This is due to the use of JGit 4.5.4
> (https://github.com/apache/maven-scm/blob/c5eb2c187568809e0dc0ea9ac83031f1dcb5ad1a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml#L53)
> which used JSch which lacks support for those private keys. JGit 5.2 comes
> with a new SSH implementation
> (https://bugs.eclipse.org/bugs/show_bug.cgi?id=520927) and should by that
> also support OpenSSH private keys.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
