rmannibucau commented on PR #765: URL: https://github.com/apache/maven/pull/765#issuecomment-1182990445
> If anyone MUST produce plugin that works with Maven2 AND Maven3, they should be aware they are missing the Maven4 train Let see, I suspect we will need to ensure it works even if done with an extension enriching plugin depencencies on the fly, there is no real good way to break our ecosystem so should be something slow. That said it does not help this topic to ensure a plugin can run on current maven version much since only way to be sure is to check the API surface which is used. > Re metadata: If we start adding metadata, propagation of that metadata will take eons thru ecosystem (with 2.x plugins being still in use), so see my "slow rant" for that. Agree, we can fallback on the bytecode visit in the meantime while this is not by default it should do the job. > IMHO instead of some "lab" (scalpel) approach, yes, this is more like "root it out" (axe or hoe), just make it gone, kill it in root. if so, let's just add in the plugin metadata the minimum maven version (potentially max?) and be it, no? > Hence, it is completely safe to assume if plugin: > > * depends on plugin-api less than 3.1 > * OR depends on maven-compat whatever 3.x version (to be added) > * => we deal with ancient plugin Sure but it is *not* safe to say it will not work with current maven version. Best example is a plugin just adding some properties in maven project, logging some meta or generating some files from a preconfigured structure, it will run fine in most cases, so ok you have an old build of a plugin but you can't conclude much right? Last thing is "depends on" means "uses in its code" and not "has it in its dependencies" so still current impl is probably too optimistic and leads to too much false positive for end user IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
