kwin commented on code in PR #3: URL: https://github.com/apache/maven-rar-plugin/pull/3#discussion_r919834606
########## src/main/java/org/apache/maven/plugins/rar/internal/RarLifecycleMappingProvider.java: ########## @@ -0,0 +1,105 @@ +package org.apache.maven.plugins.rar.internal; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import javax.inject.Named; +import javax.inject.Provider; +import javax.inject.Singleton; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.maven.lifecycle.mapping.Lifecycle; +import org.apache.maven.lifecycle.mapping.LifecycleMapping; + +/** + * {@code rar} packaging plugins bindings provider for {@code default} lifecycle. + */ +@Singleton +@Named( "rar" ) +public final class RarLifecycleMappingProvider + implements Provider<LifecycleMapping> +{ + @SuppressWarnings( "checkstyle:linelength" ) + private static final String[] BINDINGS = + { + "process-resources", "org.apache.maven.plugins:maven-resources-plugin:3.2.0:resources", Review Comment: That means e.g for Maven 3.8.6 when not defining explicit plugin versions in the pom.xml : The versions of the plugins used in the default binding for packaging `rar`: 1. Are defined by Maven Core if this plugin is not loaded with extensions classloader 2. Are defined by this plugin if it is loaded with extensions classloader (which somehow was not considered production-ready in https://github.com/apache/maven-apache-parent/pull/92) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
