michael-o commented on code in PR #106:
URL: https://github.com/apache/maven-doxia/pull/106#discussion_r916030633
##########
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##########
@@ -69,6 +72,10 @@
/** The stack. */
private final Stack<IndexEntry> stack;
+ /** A map containing all used ids of index entries as key and how often
they are used as value
+ * (0-based, i.e. 0 means used 1 time). */
+ private final Map<String, AtomicInteger> usedIds;
Review Comment:
Why atomic? All you need is a mutuable integer, no? This component is
neither singleton not in MT use.
##########
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##########
@@ -323,6 +331,26 @@ public void text( String text )
}
}
+ /**
+ * Converts the given id into a unique one by potentially suffix it with a
counter value.
+ * @param id
+ * @return the unique id
+ */
+ String getUniqueId( String id )
+ {
+ final String uniqueId;
+ if ( usedIds.containsKey( id ) )
+ {
+ uniqueId = id + "_" + usedIds.get( id ).incrementAndGet();
+ }
+ else
+ {
+ usedIds.put( id, new AtomicInteger() );
Review Comment:
What about `computeIfAbsent()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
