olamy commented on code in PR #54: URL: https://github.com/apache/maven-gh-actions-shared/pull/54#discussion_r915652972
########## .github/workflows/maven-verify.yml: ########## @@ -208,7 +208,12 @@ jobs: shell: bash - name: Clean Ensuring no file handle remains open on windows - run: ./mvnw clean --errors --batch-mode --show-version + run: ./mvnw clean --errors --batch-mode --show-version + + - name: clean local repo to ensure no locks remains on files + if: always() + run: rm -rf ~/.m2/ Review Comment: I have never been really sure if this cache works or how this cache works.... but looking at builds everywhere (this one as an example just look at this one https://github.com/apache/maven-compiler-plugin/runs/7168529515?check_suite_focus=true ) there are always tons of `[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/` for artifacts which are supposed to been already cached. Not really sure how it is efficient. I have always sceptical about this maybe there are some bad configuration? look at the debug I added some debug and `~/.m2/repository` is empty after the setup java which is supposed to handle the cache. Interesting I will try to have a look at the source code of this action/cache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org