[
https://issues.apache.org/jira/browse/MNG-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560649#comment-17560649
]
ASF GitHub Bot commented on MNG-7443:
-------------------------------------
Giovds commented on code in PR #701:
URL: https://github.com/apache/maven/pull/701#discussion_r910373496
##########
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java:
##########
@@ -254,12 +215,13 @@ private List<MavenProject> trimResumedProjects(
List<MavenProject> projects, Pro
if ( StringUtils.isNotEmpty( request.getResumeFrom() ) )
{
- File reactorDirectory = getReactorDirectory( request );
+ File reactorDirectory = !isNullOrEmpty( request.getBaseDirectory()
)
Review Comment:
Good catch, you are right. It was intended to be the follow the [original
implementation](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java#L436)
but slipped through.
> Consistent logging between optional projects and optional profiles
> ------------------------------------------------------------------
>
> Key: MNG-7443
> URL: https://issues.apache.org/jira/browse/MNG-7443
> Project: Maven
> Issue Type: Improvement
> Components: Core, Logging
> Affects Versions: 4.0.0-alpha-1
> Reporter: Giovanni van der Schelde
> Priority: Minor
> Attachments: example.png
>
>
> Maven 4 introduces optional profiles and optional projects. However, the
> feedback provided to the user on whether a project or profile has been
> skipped is inconsistent between the two (see image attached).
> For profiles, it will be logged twice: before and after the build.
> For projects, it will be logged once: before the build.
> The idea would be to log the information for skipped optional projects after
> the build as well.
> !example.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
