[ 
https://issues.apache.org/jira/browse/MNG-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558865#comment-17558865
 ] 

ASF GitHub Bot commented on MNG-7401:
-------------------------------------

michael-o commented on PR #743:
URL: https://github.com/apache/maven/pull/743#issuecomment-1166493359

   > I can write one for 
[MNG-7474](https://issues.apache.org/jira/browse/MNG-7474). 
[MNG-7401](https://issues.apache.org/jira/browse/MNG-7401) is an internal 
behavior and would require a junit test rather than an IT imho.
   
   I guess so that would be best




> Make MavenSession#getCurrentProject() using a thread local
> ----------------------------------------------------------
>
>                 Key: MNG-7401
>                 URL: https://issues.apache.org/jira/browse/MNG-7401
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 3.9.0, waiting-for-feedback
>
>
> I noticed that a session is often cloned due to change the current project 
> for a while.
> As this works for everyone passing down the session, consumers of the "upper 
> session" (e.g. a SessionScoped Component) would never see this if they are 
> (indirectly) called and e.g. use Session#getCurrentProject().
> I wonder if MavenSession could simply use a ThreadLocal for the 
> currentProject (that is shared accross all cloned sessions), that way one 
> would always get the correct value.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to