stevecrox commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166253424
I don't see any reasoning in that statement and its phrased in an unnecessary way. I've already explained sound reasons for squashing a commit. This project appears to be following some variation of [Feature Branch Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow). The key requirement of that approach is to ensure main (master is not inclusive) branch is always buildable and releasable. The only reasons a commit in a branch matter are for the reasons I've outlined. I'm not going to squash it and I figure you have the following choices. - Provide a solid engineering based reason for squashing - Accept the PR - Reject the PR If you accept it, I'll happily keep plugin away at updating the skin to Bootstrap v5 with all the UI aspects the project appears to value (I'm not sure I agree with a number of them some but whatever..). If you reject it, I'll just fork and rename the project and release it as Bootstrap v5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
