[
https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558683#comment-17558683
]
Stephen Crocker edited comment on MSKINS-97 at 6/24/22 9:28 PM:
----------------------------------------------------------------
The sidebar is lacking icons (problem for tomorrow).
Its lost the indentation and floating nature because of bootstrap spacing in
v5. Some of the navbar stuff seems to have moved to the flex system, after
spending an evening fighting it I gave up and embraced it and changed the
sidebar to be a d-flex. This is what causes the sidebar background to go to the
edges.
The text and use of upper capitals comes from the base Bootstrap theme, for the
dynamic branch I altered the mainmenu/topmenu to make use of nav-header,
nav-link, nav-item, etc.. It the basic theme nav-header will all caps titles
Also the fact the top bar/banner isn't going to the edge is bugging me, either
the sidebar needs to indent or the topbar should fully extend.
was (Author: JIRAUSER290518):
The sidebar is lacking icons (problem for tomorrow).
Its lost the indentation and floating nature because of bootstrap spacing in
v5. Some of the navbar stuff seems to have moved to the flex system, after
spending an evening fighting it I gave up and embraced it and changed the
sidebar to be a d-flex. This is what causes the sidebar background to go to the
edges.
The text and use of upper capitals comes from the base Bootstrap theme, for the
dynamic branch I altered the mainmenu/topmenu to make use of nav-header,
nav-link, nav-item, etc.. It the basic theme nav-header will all caps titles
> Upgrade to Bootstrap 5.x
> ------------------------
>
> Key: MSKINS-97
> URL: https://issues.apache.org/jira/browse/MSKINS-97
> Project: Maven Skins
> Issue Type: Task
> Components: Fluido Skin
> Reporter: Michael Osipov
> Priority: Major
> Fix For: fluido-2.0.0
>
> Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png
>
>
> Next major of Fluido should be upgraded to Bootstrap 5.x which is *not*
> backwards compatible to 2.x. See http://getbootstrap.com/migration/
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
