[ 
http://jira.codehaus.org/browse/MRELEASE-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_93939
 ] 

Max Bowsher commented on MRELEASE-137:
--------------------------------------

If the child projects depend on the root project - for example by using it as 
their parent, the root comes first. If none of the child projects depend on the 
root project, it comes last. So, position in the list is no indicator at all, 
unfortunately.


ReactorManager.getTopLevelProject() looks like it ought to give us what we want 
- unfortunately MavenSession doesn't allow access to the ReactorManager. Also 
see the note in ProjectSorter.getTopLevelProject(), saying that weirdness (i.e. 
a NPE) will happen when using "mvn -r".


I think the best short term solution is to iterate through the 
${reactorProjects} looking for one which .isExecutionRoot(). If one is not 
found, then either provide no default tag, or provide a default tag which 
contains the artifactId and version for *every* project in the reactor (thus 
handling the "mvn -r" case).

Which approach sounds sanest?

> proposed SCM release tag or label in multiproject
> -------------------------------------------------
>
>                 Key: MRELEASE-137
>                 URL: http://jira.codehaus.org/browse/MRELEASE-137
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-4
>            Reporter: Gilles Scokart
>            Assignee: Stephane Nicoll
>            Priority: Minor
>             Fix For: 2.0-beta-5
>
>         Attachments: patch.txt
>
>
> If we have
> - pom.xml (name : root)
>   --- module1
>      ---- pom.xml (name : module1)
>   --- module2
>      ---- pom.xml (name : module1)
> and we prepare a release at the root level, the name proposed for the tag is 
> module1-${version} instead  root-${version}.
> Note that except the name, everything is stored as expected with SVN.
> NB: I don't know if it has an impact, but the pom in module1 and module 
> doesn't inherit from the root (no parent tags).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to