chalmagr commented on code in PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#discussion_r889652117
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java:
##########
@@ -312,7 +312,7 @@ private void addTestMethodStats()
for ( WrappedReportEntry reportEntry :
detailsForThis.getReportEntries() )
{
TestMethodStats methodStats =
- new TestMethodStats( reportEntry.getClassMethodName(),
reportEntry.getReportEntryType(),
+ new TestMethodStats( reportEntry.getReportClassMethodName(),
reportEntry.getReportEntryType(),
Review Comment:
Right... Was looking into my previous thought and was able to confirm that
it was indeed ok and wasn't really affecting it as it depends on the
provider... eventually ended up in this RunListenerAdapter class as well, and
the logic there is quite overwhelming and a bit scary :) I have made changes to
that class only now (without all the other changes) and it does seem to be ok,
as suggested.
I've added a junit4 table with the different scenarios so that it has some
examples on it. There is a different issue I found (when miss-using the junit4
displayName to not contain the parameter; causing same problem.. it is possible
to avoid it, but requires messing with the UniqueID .. probably not the best
since it may change... anyways, when attempting 2nd run on the failed tests
(even with proper handling), junit4 fails to run only the failed and re-runs
all the ones that match the 'displayName' ... but again, since this is some
very odd case that I hope nobody is using (And should be discouraged I guess by
some warnings when not adding {0} or anything to it)
Will run some more tests and see if I can update this PR to use the newly
created branch with less changes or if I should overwrite my branch's history
... will update this PR soon
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
