[
https://issues.apache.org/jira/browse/SCM-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544595#comment-17544595
]
ASF GitHub Bot commented on SCM-939:
------------------------------------
nielsbasjes commented on code in PR #150:
URL: https://github.com/apache/maven-scm/pull/150#discussion_r886110692
##########
maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java:
##########
@@ -79,36 +85,33 @@ protected void setUp()
checkoutMojo.execute();
}
+ @Test
public void testBranch()
throws Exception
{
- if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
- {
- ScmTestCase.printSystemCmdUnavail(
SvnScmTestUtils.SVN_COMMAND_LINE, getName() );
- return;
- }
+ checkScmPresence( SvnScmTestUtils.SVNADMIN_COMMAND_LINE, "testBranch"
);
BranchMojo mojo =
- (BranchMojo) lookupMojo( "branch", getTestFile(
"src/test/resources/mojos/branch/branch.xml" ) );
+ (BranchMojo) lookupMojo( "branch",
PlexusJUnit4TestSupport.getTestFile(
"src/test/resources/mojos/branch/branch.xml" ) );
Review Comment:
So just to be clear. I'm totally fine if you guys pick this one up.
I'm stuck here.
> Assume SCM is present
> ---------------------
>
> Key: SCM-939
> URL: https://issues.apache.org/jira/browse/SCM-939
> Project: Maven SCM
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Priority: Minor
>
> We have a lot of tests that do something like this:
>
> if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
> {
> ScmTestCase.printSystemCmdUnavail( SvnScmTestUtils.SVN_COMMAND_LINE,
> getName() );
> return;
> }
>
> We should instead use org.*junit*.*Assume* here so these are marked as
> skipped rather than passed.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
