[
https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543687#comment-17543687
]
ASF GitHub Bot commented on MNG-7476:
-------------------------------------
michael-o commented on code in PR #736:
URL: https://github.com/apache/maven/pull/736#discussion_r884276548
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##########
@@ -220,20 +223,44 @@ private void execute( MavenSession session, MojoExecution
mojoExecution, Project
* TODO: ideally, the builder should take care of the ordering in a
smarter way
* TODO: and concurrency issues fixed with MNG-7157
*/
- private static class ProjectLock implements AutoCloseable
+ private class ProjectLock implements AutoCloseable
{
final Lock acquiredAggregatorLock;
- final Lock acquiredProjectLock;
+ final OwnerReentrantLock acquiredProjectLock;
- ProjectLock( MavenSession session, MojoDescriptor mojoDescriptor,
ReadWriteLock aggregatorLock )
+ ProjectLock( MavenSession session, MojoDescriptor mojoDescriptor )
{
+ mojos.put( Thread.currentThread(), mojoDescriptor );
Review Comment:
this duplicates
https://github.com/apache/maven/pull/736/files#diff-afa12cb60ed6ee8f6ad777fc0a0b4db1726b94306d7bda74f930ee95a27a9195R350.
Intended? I assume since the finally block removes, this must go and the
caller's put will remain.
> Display a warning when an aggregator mojo is locking other mojo executions
> --------------------------------------------------------------------------
>
> Key: MNG-7476
> URL: https://issues.apache.org/jira/browse/MNG-7476
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 3.8.5
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
