[ 
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542404#comment-17542404
 ] 

ASF GitHub Bot commented on SCM-989:
------------------------------------

michael-o commented on code in PR #149:
URL: https://github.com/apache/maven-scm/pull/149#discussion_r882444380


##########
maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/CheckoutMojoTest.java:
##########
@@ -81,6 +81,12 @@ public void testSkipCheckoutWithConnectionUrl()
 
         SvnScmTestUtils.initializeRepository( repository );
 
+        if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
+        {
+            ScmTestCase.printSystemCmdUnavail( 
SvnScmTestUtils.SVN_COMMAND_LINE, getName() );
+            return;
+        }
+

Review Comment:
   There is a problem, I have a local branch which uses your new code:
   ```diff
   diff --git 
a/maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java
 
b/maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java
   index ef788478..33d27e7f 100644
   -

> Tests fail if svn and/or git are not installed
> ----------------------------------------------
>
>                 Key: SCM-989
>                 URL: https://issues.apache.org/jira/browse/SCM-989
>             Project: Maven SCM
>          Issue Type: Test
>            Reporter: Niels Basjes
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the 
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR]   SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing 
> svn command.
> [ERROR]   SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while 
> executing svn command.{code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to