[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541839#comment-17541839
]
ASF GitHub Bot commented on SCM-986:
------------------------------------
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881251864
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##########
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+ extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+ @Override
+ protected ScmProviderRepository getScmProviderRepository()
+ throws Exception
+ {
+ return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
That's the cheap solution
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -----------------------------------------------------
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
> Affects Versions: 2.0.0-M1, 1.12.2
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
