[GitHub] [maven-scm] michael-o commented on a diff in pull request #141: [SCM-979] De-Plexus, Java8

[GitBox]

michael-o commented on code in PR #141:
URL: https://github.com/apache/maven-scm/pull/141#discussion_r878740436


##########
maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java:
##########
@@ -44,47 +51,44 @@
 import org.apache.maven.scm.command.unedit.UnEditScmResult;
 import org.apache.maven.scm.command.update.UpdateScmResult;
 import org.apache.maven.scm.log.ScmLogger;
+import org.apache.maven.scm.log.Slf4jScmLogger;
 import org.apache.maven.scm.provider.ScmProvider;
 import org.apache.maven.scm.provider.ScmProviderRepository;
 import org.apache.maven.scm.provider.ScmUrlUtils;
 import org.apache.maven.scm.repository.ScmRepository;
 import org.apache.maven.scm.repository.ScmRepositoryException;
 import org.apache.maven.scm.repository.UnknownRepositoryStructure;
+import org.slf4j.LoggerFactory;
 
-import java.io.File;
-import java.util.ArrayList;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
+import static java.util.Objects.requireNonNull;
 
 /**
  * @author <a href="mailto:tryg...@inamo.no";>Trygve Laugst&oslash;l</a>
  * @author <a href="mailto:br...@apache.org";>Brett Porter</a>
  * @author <a href="mailto:eveni...@apache.org";>Emmanuel Venisse</a>
- *
  */
 public abstract class AbstractScmManager
-    implements ScmManager
+        implements ScmManager
 {
-    private Map<String, ScmProvider> scmProviders = new HashMap<String, 
ScmProvider>();
+    private final ScmLogger logger = new Slf4jScmLogger( 
LoggerFactory.getLogger( getClass() ) );
 
-    private ScmLogger logger;
+    private final Map<String, ScmProvider> scmProviders = new 
ConcurrentHashMap<>();
 
-    private Map<String, String> userProviderTypes = new HashMap<String, 
String>();
+    private final Map<String, String> userProviderTypes = new 
ConcurrentHashMap<>();
 

Review Comment:
   Concurrent because this component is a singleton?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org