mthmulders commented on code in PR #143:
URL: https://github.com/apache/maven-scm/pull/143#discussion_r878473196
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/remoteinfo/GitExeRemoteInfoCommandTckTest.java:
##########
@@ -23,6 +23,8 @@
import org.apache.maven.scm.provider.git.GitScmTestUtils;
import
org.apache.maven.scm.provider.git.command.remoteinfo.AbstractGitRemoteInfoCommandTckTest;
+import static org.junit.Assert.assertEquals;
Review Comment:
I don't understand why this import is added; it is the only change in this
file?
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommandCommitterAuthorTckTest.java:
##########
@@ -54,7 +60,7 @@
{
@Override
- protected void setUp()
+ public void setUp()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@Before` (in
JUnit 4 style)?
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommandTckTest.java:
##########
@@ -29,6 +29,8 @@
import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository;
import org.eclipse.jgit.util.FileUtils;
+import static org.junit.Assert.assertEquals;
Review Comment:
I don't understand why this import is added; it is the only change in this
file?
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svntest/src/main/java/org/apache/maven/scm/provider/svn/command/blame/SvnBlameCommandTckTest.java:
##########
@@ -27,6 +27,8 @@
import java.io.File;
import java.util.List;
+import static org.junit.Assert.assertEquals;
Review Comment:
I don't understand why this import is added; it is the only change in this
file?
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommandCommitterAuthorTckTest.java:
##########
@@ -63,7 +69,7 @@ protected void setUp()
}
@Override
- protected void tearDown()
+ public void tearDown()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@After` (in
JUnit 4 style)?
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTckTest.java:
##########
@@ -24,6 +24,8 @@
import
org.apache.maven.scm.provider.svn.command.remoteinfo.AbstractSvnRemoteInfoCommandTckTest;
import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+import static org.junit.Assert.assertTrue;
Review Comment:
I don't understand why this import is added; it is the only change in this
file?
##########
maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/command/blame/HgBlameCommandTckTest.java:
##########
@@ -26,6 +26,8 @@
import java.util.List;
+import static org.junit.Assert.assertEquals;
Review Comment:
I don't understand why this import is added; it is the only change in this
file?
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/mkdir/SvnMkdirCommandTest.java:
##########
@@ -56,21 +59,23 @@ protected void setUp()
messageFileString = "--file " + path + " --encoding UTF-8";
}
- protected void tearDown()
+ public void tearDown()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@After` (in
JUnit 4 style)?
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##########
@@ -135,10 +138,9 @@ public void removeRepo()
/**
* Provided to allow removeRepo() to be called.
- * @see junit.framework.TestCase#tearDown()
*/
@Override
- protected void tearDown()
+ public void tearDown()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@After` (in
JUnit 4 style)?
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogConsumerTest.java:
##########
@@ -39,19 +40,23 @@
import java.util.TimeZone;
import java.util.concurrent.atomic.AtomicInteger;
+import static junit.framework.TestCase.assertTrue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
/**
* @author <a href="mailto:eveni...@apache.org";>Emmanuel Venisse</a>
*
*/
public class SvnChangeLogConsumerTest
- extends PlexusTestCase
+ extends ScmTestCase
{
Logger logger = LoggerFactory.getLogger( getClass() );
SvnChangeLogConsumer consumer;
- protected void setUp()
+ public void setUp()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@Before` (in
JUnit 4 style)?
##########
maven-scm-test/pom.xml:
##########
@@ -60,7 +60,6 @@
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>no_aop</classifier>
- <scope>runtime</scope>
Review Comment:
Is this related to dropping JUnit 3?
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java:
##########
@@ -60,7 +63,8 @@
private SecDispatcher secDispatcher;
- protected void setUp()
+ @Override
+ public void setUp()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@Before` (in
JUnit 4 style)?
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##########
@@ -98,14 +101,14 @@ public abstract void initRepo()
/**
* {@inheritDoc}
*/
- protected void setUp()
+ public void setUp()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@Before` (in
JUnit 4 style)?
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/mkdir/SvnMkdirCommandTest.java:
##########
@@ -39,7 +42,7 @@
String messageFileString;
- protected void setUp()
+ public void setUp()
Review Comment:
Apparently, this still works (at least, no tests seem to be failing because
this doesn't run) but wouldn't it be more nice to annotate with `@Before` (in
JUnit 4 style)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
