[GitHub] [maven-release] michael-o commented on a diff in pull request #121: [MRELEASE-1082] configuration option for using a shallow clone

[GitBox]

michael-o commented on code in PR #121:
URL: https://github.com/apache/maven-release/pull/121#discussion_r867354841


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java:
##########
@@ -473,6 +473,19 @@ public ReleaseDescriptorBuilder setScmCommentPrefix( 
String scmCommentPrefix )
         return this;
     }
 
+    /**
+     * <p>setScmShallowClone.</p>
+     *
+     * @param scmShallowClone a boolean
+     * @return a {@link 
org.apache.maven.shared.release.config.ReleaseDescriptorBuilder} object
+     * since 3.0.0-M6

Review Comment:
   `@since`



##########
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/AbstractScmReleaseMojo.java:
##########
@@ -89,6 +89,12 @@
     @Parameter( defaultValue = "[maven-release-plugin] ", property = 
"scmCommentPrefix" )
     private String scmCommentPrefix;
 
+    /**
+     * When cloning a repository if it should be a shallow clone or a full 
clone.
+     */
+    @Parameter( defaultValue = "true", property = "shallowClone" )
+    private boolean shallowClone = true;

Review Comment:
   Shouldn't this be `scmShallowClone` for consistency reasons?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org