[GitHub] [maven-release] michael-o commented on a diff in pull request #120: [MRELEASE-1088] Remove parsing of CLI arguments

[GitBox]

michael-o commented on code in PR #120:
URL: https://github.com/apache/maven-release/pull/120#discussion_r866738885


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -400,10 +119,11 @@ public void executeGoals( File workingDirectory, 
List<String> goals, ReleaseEnvi
                     throw new MavenExecutorException( "Error executing Maven.",
                                                       
invocationResult.getExecutionException() );
                 }
+
                 if ( invocationResult.getExitCode() != 0 )
                 {
                     throw new MavenExecutorException(
-                        "Maven execution failed, exit code: \'" + 
invocationResult.getExitCode() + "\'",
+                        "Maven execution failed, exit code: '" + 
invocationResult.getExitCode() + "'",

Review Comment:
   I think, the single quotes are redundant: (1) it is a number, (2) we have a 
colon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org