michael-o commented on code in PR #168: URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857161165
########## src/site/markdown/local-repository.md: ########## @@ -83,6 +83,12 @@ need to re-download the "whole universe". Similarly, deletion of cached ones can happen based even on origin repository (if split by remote repository was enabled beforehand). +Example configuration with split by remote repository: +```java +$ mvn ... -Daether.enhancedLocalRepository.split=true \ + -Daether.enhancedLocalRepository.splitRemoteRepository=true Review Comment: According to my tests even `=true` is not necessary and implied by the system ########## src/site/markdown/local-repository.md: ########## @@ -91,12 +97,21 @@ would constantly overwrite each other. It was easy to get into "false error" state, where partial overlapping content were present in local repository from different branches. Today, one can just define unique "local prefix" for each branch it is working on (or even by project, like -`-Daether.enhancedLocalRepository.localPrefix=${project}/${branch}`) and the +`-Daether.enhancedLocalRepository.localPrefix=$PROJECT/$BRANCH`, but use +actual values, these expressions are merely example, there is no interpolation Review Comment: an exmaple ########## src/site/markdown/local-repository.md: ########## @@ -91,12 +97,21 @@ would constantly overwrite each other. It was easy to get into "false error" state, where partial overlapping content were present in local repository from different branches. Today, one can just define unique "local prefix" for each branch it is working on (or even by project, like -`-Daether.enhancedLocalRepository.localPrefix=${project}/${branch}`) and the +`-Daether.enhancedLocalRepository.localPrefix=$PROJECT/$BRANCH`, but use +actual values, these expressions are merely example, there is no interpolation +happening!) and the local repository becomes usable even simultaneously, even concurrently from different terminals, as different projects and their branches can simply coexist in local repository. They will land in different places, due different prefixes. +Example configuration for branches: +```java +$ mvn ... -Daether.enhancedLocalRepository.split=true \ + -Daether.enhancedLocalRepository.localPrefix=maven-resolver/mresolver-253 + -Daether.enhancedLocalRepository.splitRemoteRepository=true Review Comment: Same here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org