[ 
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523432#comment-17523432
 ] 

Maarten Mulders edited comment on SUREFIRE-2063 at 4/17/22 7:15 PM:
--------------------------------------------------------------------

I've run the project with {{mvn -X}}, and observed an interesting difference in 
the output.

With Surefire 3.0.0-M5:
{code}[DEBUG] Forking command line: /bin/sh -c cd 
/Users/maarten/Junk/surefire-bug/module1 && 
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/java 
--add-opens 
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED          
              --add-opens 
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED 
@/Users/maarten/Junk/surefire-bug/module1/target/surefire/surefireargs3750425927935805323
 /Users/maarten/Junk/surefire-bug/module1/target/surefire 
2022-04-12T12-19-27_455-jvmRun1 surefire10840194083466728669tmp 
surefire_017868848018900059027tmp
{code}

With Surefire 3.0.0-M6:
{code}[DEBUG] Forking command line: /bin/sh -c cd 
'/Users/maarten/Junk/surefire-bug/module1' && 
'/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/java' 
'--add-opens' 
'org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED' '      
                --add-opens' 
'org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED' 
'@/Users/maarten/Junk/surefire-bug/module1/target/surefire/surefireargs18068527077933644869'
 '/Users/maarten/Junk/surefire-bug/module1/target/surefire' 
'2022-04-12T12-15-39_065-jvmRun1' 'surefire5839325282694079238tmp' 
'surefire_01690065092548918203tmp'
{code}

Note how, with M6, the spaces (or tabs) from the POM seem to get back into the 
forked JVM argument list. I've manually tried to remove them and that made the 
invocation succeed. I'll create a pull request to fix this.


was (Author: mthmulders):
I've run the project with {{mvn -X}}, and observed an interesting difference in 
the output.

With Surefire 3.0.0-M5:
{code}[DEBUG] Forking command line: /bin/sh -c cd 
/Users/maarten/Junk/surefire-bug/module1 && 
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/java 
--add-opens 
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED          
              --add-opens 
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED 
@/Users/maarten/Junk/surefire-bug/module1/target/surefire/surefireargs3750425927935805323
 /Users/maarten/Junk/surefire-bug/module1/target/surefire 
2022-04-12T12-19-27_455-jvmRun1 surefire10840194083466728669tmp 
surefire_017868848018900059027tmp
{code}

With Surefire 3.0.0-M6:
{code}[DEBUG] Forking command line: /bin/sh -c cd 
'/Users/maarten/Junk/surefire-bug/module1' && 
'/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/java' 
'--add-opens' 
'org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED' '      
                --add-opens' 
'org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED' 
'@/Users/maarten/Junk/surefire-bug/module1/target/surefire/surefireargs18068527077933644869'
 '/Users/maarten/Junk/surefire-bug/module1/target/surefire' 
'2022-04-12T12-15-39_065-jvmRun1' 'surefire5839325282694079238tmp' 
'surefire_01690065092548918203tmp'
{code}

Note how, with M6, the spaces (or tabs) from the POM seem to get back into the 
forked JVM argument list. I'll create a pull request to fix this.

> Adding configuration using <argLine> with --add-opens or --add-exports fails
> ----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-2063
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 3.0.0-M6
>            Reporter: Daniel Subelman
>            Priority: Blocker
>
> Since v3.3.0-M6 fails when using <argLine> to export or open a package. The 
> failure is produced when using --add-opens or --add-exports in <argLine>.
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following <argLine>:
> {code:java}
> <argLine>
>     --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
>     --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
> </argLine>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider 
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO] 
> [INFO] -------------------------------------------------------
> [INFO]  T E S T S
> [INFO] -------------------------------------------------------
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time:  9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project 
> testing: 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to