michael-o commented on code in PR #705:
URL: https://github.com/apache/maven/pull/705#discussion_r847030748
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java:
##########
@@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String
fieldName, Object value, Ob
{
delegate.notifyFieldChangeUsingReflection( fieldName, value, target );
- if ( mojo == target )
+ if ( mojo == target && value != null )
{
notify( fieldName, value );
}
}
private void notify( String fieldName, Object value )
{
- if ( value != null )
+ missingParameters.remove( fieldName );
+
+ if ( logger.isWarnEnabled() )
+ {
+ warnDeprecated( fieldName, value );
+ }
+ }
+
+ private void warnDeprecated( String fieldName, Object value )
+ {
+ Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName
);
+ String deprecated = parameter.getDeprecated();
+ if ( deprecated != null && !deprecated.isEmpty() )
+ {
+ Object defaultValue = evaluateValue( parameter.getDefaultValue() );
+ if ( !toString( value ).equals( toString( defaultValue ) ) )
+ {
+ StringBuilder sb = new StringBuilder( " Parameter '" );
+ sb.append( fieldName ).append( '\'' );
+ if ( parameter.getExpression() != null )
+ {
+ String userProperty = parameter.getExpression().replace(
"${", "'" ).replace( '}', '\'' );
+ sb.append( " (User Property " ).append( userProperty
).append( ")" );
+ }
+ sb.append( " is deprecated. " ).append( deprecated );
Review Comment:
Looking into, but this feels extremely ugly and inconsistent (not your
fault). `MojoDescriptor#getDeprecated()` (sic!) says `true`/`false` as string
while parameter says nothing. It would expect same behavior. So if this is
truly linked to `@deprecated` in Javadoc, then `MojoDescriptor` behavior is
wrong.
What is `@Deprecated` is given, but not `@deprecated` in Javadoc?
Looking at
`org.apache.maven.plugin.descriptor.PluginDescriptorBuilderTest.testBuildReader()`
shows that it is not boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
