zoltanmeze opened a new pull request, #518:
URL: https://github.com/apache/maven-surefire/pull/518
Two cases are covered here:
* Test run swallowing some of the outputs and finishing with the following
warning:
```
[WARNING] Corrupted channel by directly writing to native stream in forked
JVM 1.
```
* Test run getting completely stuck
Both cases are caused by the same issue, output buffer overflow in
[AbstractStreamDecoder#readString(Memento,
int)](https://github.com/apache/maven-surefire/blob/master/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoder.java#L302),
because output char buffer is not cleared if it's not completely full.
Added unit tests:
* AbstractStreamDecoderTest#shouldReadStringOverflowOnNewLine:
Input buffer of 1026 bytes: 1023 x 1-byte + 1 x 2-bytes encoded character
+ new line (LF).
* In first iteration it decodes the first 1023 bytes from the input buffer
without clearing the output buffer.
* In second iteration `decodeString` returns an overflow, but it still
force reads the 2-byte encoded character from input to output. `readString`
ends up with 1 remaining byte (LF) on input buffer causing channel to become
corrupted.
* AbstractStreamDecoderTest#shouldReadStringOverflowOn4BytesEncodedSymbol:
Input buffer of 1027 bytes: 1023 x 1 byte + 1 x 4-bytes encoded
characters.
* In first iteration it decodes the first 1023 bytes from the input buffer
without clearing the output buffer.
* In second iteration `decodeString` returns an overflow, without reading
anything from input buffer. This is causing an infinite loop in `readString`,
it never exits.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
