sbabcoc commented on PR #517: URL: https://github.com/apache/maven-surefire/pull/517#issuecomment-1093056148
In this PR, I fixed issues with handling of the [parallel] option in the existing implementation. However, I've since noticed that this class lacks implementation that would produce corresponding command line options for the options it supports. Also, no handling was provided for potential `NumberFormatException` failures. Finally, no unit tests were implemented for this class. These were potentially skipped because the version of TestNG specified by this project's dependencies (v5.10) pre-dates the introduction of the supported features. These deficiencies should be addressed to maintain the quality of the Surefire project. I'll switch this PR to "draft" mode and see what I can do about the unit test issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
