[ https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514510#comment-17514510 ]
Robert Stupp commented on MSHADE-413: ------------------------------------- > I can't even compile the whole project That's weird. The repository's [configured here|https://github.com/projectnessie/nessie/blob/main/clients/deltalake/pom.xml#L116-L122]. Maybe something with your local settings? > I can not reproduce the Step 4. because I can run it without any issue There's a reproducer on the PR as well. Have you tried it? The symptoms are exactly the same as reported by many other people (MNG-7096, the unmerged PR on MSHADE-148, MSHADE-384 and couple of mentions elsewhere, sometimes with the workaround to set {{promoteTransitiveDependencies=true}}, which is a change to the behavior). > Maven share plugin enters endless loop > --------------------------------------- > > Key: MSHADE-413 > URL: https://issues.apache.org/jira/browse/MSHADE-413 > Project: Maven Shade Plugin > Issue Type: Bug > Affects Versions: 3.2.4 > Reporter: Robert Stupp > Priority: Critical > > Two issues at play here: > * {{ShadeMojo.createDependencyReducedPom()}} pulls in {{origDeps = > project.getDependencies()}} and later modifies these {{Dependency}} objects. > * {{ShadeMojo.updateExcludesInDeps()}} enters it's own endless loop, > endlessly adding the exact same exclusions. > This leads to a > [reproducible|https://github.com/projectnessie/nessie/issues/3678] endless > loop (see below). > If the Shade plugin's not using the {{Dependency}} objects "owned by Maven > itself" (by setting {{promoteTransitiveDependencies}} to {{true}}), the build > passes fine. > I think, _modifying_ the {{Dependency}} objects "owned by Maven itself" is > bad for two reasons (which IMO justify the increased priority of this > ticket): > # the reproducible endless loop > # it breaks the correctness of the project build - at least plugins running > after the {{shade}} goal that use those dependencies. -- This message was sent by Atlassian Jira (v8.20.1#820001)