slawekjaranowski commented on a change in pull request #207:
URL:
https://github.com/apache/maven-dependency-plugin/pull/207#discussion_r835229962
##########
File path: src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java
##########
@@ -416,6 +416,10 @@ else if ( "dot".equals( outputType ) )
{
return new DOTDependencyNodeVisitor( writer );
}
+ else if ( "json".equals( outputType ) )
+ {
+ return new JSONDependencyNodeVisitor( writer );
+ }
Review comment:
can be replaced by `switch` statement
##########
File path:
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java
##########
@@ -141,9 +141,32 @@ public void _testTreeTGFSerializing()
assertTrue( findString( contents,
"testGroupId:release:jar:1.0:compile" ) );
}
+ /**
+ * Test the JSON format serialization
+ *
+ * @throws Exception in case of an error.
+ */
+ public void _testTreeJSONSerializing()
Review comment:
Please write dedicated test for new class `JSONDependencyNodeVisitor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
