gzm55 edited a comment on pull request #33: URL: https://github.com/apache/maven-wrapper/pull/33#issuecomment-1075059525
> While trying to skip the maven-wrapper.jar might be a nice goal, this creates a dependency on some external tools like `unzip`, and on some environments like containers this is an issue: > > ```shell > docker run -it --rm eclipse-temurin:17.0.2_8-jdk sh -c unzip > sh: 1: unzip: not found > ``` > > So, -1 from my side. > > Also, opening two different PRs (#35) that are related to the same issue and that both touch the same files is not a good approach. ok, #35 is closed, i will merge the mvnw.cmd part into this pr. thanks to point out the unzip dependency. i think this dependency is not a big problem. on this environment, we can still depends on the java source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
