[ 
https://issues.apache.org/jira/browse/MWRAPPER-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510392#comment-17510392
 ] 

ASF GitHub Bot commented on MWRAPPER-61:
----------------------------------------

jorsol commented on pull request #33:
URL: https://github.com/apache/maven-wrapper/pull/33#issuecomment-1075003132


   While trying to skip the maven-wrapper.jar might be a nice goal, this 
creates a dependency on some external tools like `unzip`, and on some 
environments like containers this is an issue:
   
   ```bash
   docker run -it --rm eclipse-temurin:17.0.2_8-jdk sh -c unzip
   sh: 1: unzip: not found
   ```
   
   So, -1 from my side.
   
   Also, opening two different PRs 
(https://github.com/apache/maven-wrapper/pull/35) that are related to the same 
issue and that both touch the same files is not a good approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> let mvnw call mvn directly
> --------------------------
>
>                 Key: MWRAPPER-61
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-61
>             Project: Maven Wrapper
>          Issue Type: Improvement
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.1.0
>            Reporter: James Z.M. Gao
>            Priority: Major
>
> try to skip maven-wrapper.jar, call mvn directly from mvnw.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to