[ 
https://issues.apache.org/jira/browse/SUREFIRE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509397#comment-17509397
 ] 

Tibor Digana commented on SUREFIRE-2037:
----------------------------------------

[~crizzis_dna]
My problem is that we have opened SPI interface for TestSources but we did not 
implement it.
The {{surefire-junit-platform}} with classes and methods was the first step to 
introduce this provider into the world because that time there was 100% users 
with test classes.
If we want to continue with supporting more than classes, we have only one 
option to support the rest of TestSources in this project and not outside of 
the plugin or project - behind SPI.  It is not realistic situation that the 
users will implement it by themselves. They do not have time to do it. They 
want to specify a new version of plugin in the POM or they use new version of 
Maven which has this version in default bindings and that's whole business. The 
main goal of the plugin is to execute the tests but it is not realistic to 
shift it to somewhere and make this basic functionality plugin-able again apart.
So yes, if we want to continue with multiple TestSources then we should 
implement them inside in this project and not outside. This should be our work.

> Allow for surefire-junit-platform's TestMethodFilter to support custom 
> TestSources
> ----------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-2037
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2037
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: JUnit 5.x support
>    Affects Versions: 3.0.0-M5
>            Reporter: Krzysztof Sierszeń
>            Priority: Minor
>
> Since JUnit 5 allows for custom {{{}TestSource{}}}s to be configured, 
> {{TestMethodFilter}} could provide a way for those sources to be recognized 
> and filterable. This way, custom method sources will enjoy the same filtering 
> capabilities that method sources do. 
> For now, this change specifically targets ArchUnit's {{FieldSource}}, and I'm 
> planning to use the solution provided to solve [the following 
> issue|https://github.com/TNG/ArchUnit/issues/641]. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to