laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1072344466
Not sure, at least this does restores the previous behavior. The problem is caused by the following (we have noticed something similar in Tycho as well): 1. `MavenWorkspaceReader` has the method `findModel` 2. But the chained reader has not implemented this 3. The reactor reader implement it on the other hand 4. at two places in maven it is explicitly queried for the `MavenWorkspaceReader#findModel` what produces slightly different results: 1. Lets assume we have a dependency build by the current reactor and referenced in another project, then the model might be read again with different outcome (e.g. because of https://www.mojohaus.org/flatten-maven-plugin/plugin-info.html used) 2. When using profiles, it seems to modify the in memory model returned by `MavenWorkspaceReader#findModel`, but if that is read from disk the additions from the profile are missing The fix do the following: 1. return the ReactorWorspaceReader if it is the only WSR (as in Maven 3.8.4) 2. implement `MavenWorkspaceReader#findModel` in a chained mode this should fix all this issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
