cstamas commented on a change in pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#discussion_r825363398
########## File path: maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/checksum/ArtifactChecksumFilter.java ########## @@ -0,0 +1,44 @@ +package org.eclipse.aether.spi.connector.checksum; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.eclipse.aether.artifact.Artifact; + +/** + * Filter that is able to tell does artifact have expected checksums or not. Most notably, artifacts like + * different kind of signatures will not have checksums. + * + * @since 1.8.0 + */ +public interface ArtifactChecksumFilter Review comment: hm, this needs more refactoring: I just realized, this is internal matter of Maven2RepositoryLayoutFactory. Still, IMO we do want to have it extensible, but as is in this PR, it seems misleading, as it's factory is really neglecting passed in repository completely, while all this applies to maven2 layout only. Also, I don't think a generic factory is right here, hence, I dislike to copy+paste same logic as in maven2 layout factory... Finally, I'd make this part of layout, not checksum package, maybe even just as a method on RepositoryLayout (to expose it) but it would be used internally by maven2 layout to decide... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
