laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1065068471
> For the record, the lookup of the `MojosExecutionStrategy` which was introduced by [1954d51](https://github.com/apache/maven/commit/1954d51ff2841045b4af8a515ad0719805269d8d) is definitely wrong and the lookup should be either performed explicitly using the container or better with an injected `Provider` as explained in [Guice](https://github.com/google/guice/wiki/InjectingProviders#providers-for-mixing-scopes). Also just for the record: You won't have noticed this bug without the fix applied in https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7 and that's why I'm so eager to fix bad usage of CCL/leakage as these hides hard to track problems you can spend hours of debugging and banging your head on the wall, even though most of the time people don't feel its a problem or even don't think its worth a change see https://issues.apache.org/jira/browse/CAMEL-10456 for another nasty problem in that category. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
