laeubi commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1064292516


   > Actually, the one that cause problems is the 
[BuildCacheMojosExecutionStrategy](https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java),
   
   Does this actually has to be session scoped at all? As the session is passed 
in is it really session scoped? Is the problem in the class itself or is the 
class not discovered? Because `MojoExecutor` is a singelton I don't think it 
actually is valid to assume it could use anything session/project scoped. If 
that is to be supported, I thin the `MojosExecutionStrategy` should not be 
injected but locked up for each project in `MojoExecutor.execute(MavenSession, 
List<MojoExecution>, ProjectIndex)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to