olamy commented on a change in pull request #55:
URL: https://github.com/apache/maven-parent/pull/55#discussion_r815431235



##########
File path: pom.xml
##########
@@ -1170,6 +1170,7 @@ under the License.
         <executions>
           <execution>
             <id>checkstyle-check</id>
+            <phase>validate</phase>

Review comment:
       correct so maybe generate-sources phase.
   but do we really care about checkstyle generated code?
   in this case we need to ask the plugin authors to change the style of the 
generated code? 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to