[
https://issues.apache.org/jira/browse/SUREFIRE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496360#comment-17496360
]
Tibor Digana edited comment on SUREFIRE-2000 at 2/22/22, 10:32 PM:
-------------------------------------------------------------------
[~sjaranowski]
This reproducible project appears in our integration tests:
https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-runner
The point is to run
[JUnit5Tests.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/resources/junit5-runner/src/test/java/pkg/JUnit5Tests.java]
which is JUnit4 class annotated by JUnit4 annotation activating JUnit5 Runner,
see
{code:java}
@RunWith(JUnitPlatform.class)
{code}
It is expected that this suite runs
[ATest.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/resources/junit5-runner/src/test/java/examples/a/ATest.java].
We do not have a clear evidence whether this test is executed and we do not
know how many tests are executed in real, because the integration test
[Surefire1787JUnit5IT.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java#L116]
does not verify the number of tests and names of tests. So it means that we do
not know if JUnit4 Provider is executed in this IT or JUnit5 Provider is
executed.
According to your analysis, the JUnit4 Provider is activated.
So IMHO, we should improve the verification in the integration test
[Surefire1787JUnit5IT.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java#L116],
fix this test and then we will make a new step for a fixing a problem if
exists.
was (Author: tibor17):
[~sjaranowski]
This reproducible project appears in our integration tests:
https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-runner
The point is to run
[JUnit5Tests.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/resources/junit5-runner/src/test/java/pkg/JUnit5Tests.java]
which is JUnit4 class annotated by JUnit4 annotation activating JUnit5 Runner,
see
{code:java}
@RunWith(JUnitPlatform.class)
{code}
It is expected that this suite runs
[ATest.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/resources/junit5-runner/src/test/java/examples/a/ATest.java].
We do not have a clear evidence whether this test is executed and we do not
know how many tests are executed in real, because the integration test
[Surefire1787JUnit5IT.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java#L116]
does not verify the number of tests and names of tests. So it means that we do
not know if JUnit4 Provider is executed in this IT or JUnit5 Provider is
executed.
According your analysis, the JUnit4 Provider is activated.
So IMHO, we should improve the verification in the integration test
[Surefire1787JUnit5IT.java|https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java#L116],
fix this test adn then we will make a new step for a fixing a problem if
exists.
> Classpath contains redundant JAR artifacts if ShadeFire provider is active
> --------------------------------------------------------------------------
>
> Key: SUREFIRE-2000
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2000
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin,
> surefire-shadefire
> Affects Versions: 3.0.0-M5
> Reporter: Tibor Digana
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: MANIFEST.MF-for-M4, MANIFEST.MF-for-M5,
> MANIFEST.MF-for-M6, junit5-runner.tgz
>
>
> There are extra more artifacts than necessary on the classpath if ShadeFire
> provider is used. This may cause new conflicts if testing Surefire itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
