gnodet commented on a change in pull request #27:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/27#discussion_r798720059
##########
File path: doxia-decoration-model/pom.xml
##########
@@ -36,16 +36,22 @@ under the License.
<dependencies>
<dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-component-annotations</artifactId>
+ <groupId>org.eclipse.sisu</groupId>
+ <artifactId>org.eclipse.sisu.plexus</artifactId>
+ <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
+ <version>1</version>
Review comment:
I must admit I have quite a hard time to understand the `provided` scope
which seems to depend on how you suppose the module will be used. In this
case, I don't know much about doxia, so I'll defer to you. Fwiw, the plexus
annotations were in the default scope, so I used the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
