gnodet commented on a change in pull request #164:
URL: https://github.com/apache/maven-indexer/pull/164#discussion_r797445126
##########
File path:
indexer-reader/src/test/java/org/apache/maven/index/reader/TestSupport.java
##########
@@ -54,9 +56,7 @@
public void setup()
throws IOException
{
- this.tempDir = new File( "target/tmp-" + getClass().getSimpleName() );
- this.tempDir.delete();
- this.tempDir.mkdirs();
+ this.tempDir = Files.createTempDirectory( getClass().getSimpleName() +
".temp" ).toFile();
this.directoryResourceHandlers = new ArrayList<>();
Review comment:
I don't like creating temp directories in tests:
* it's not deleted
* it's hard to find
* if the directory is deleted at the end of the test, its not available
anymore to debug the test if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
