gnodet commented on a change in pull request #668:
URL: https://github.com/apache/maven/pull/668#discussion_r795705038
##########
File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java
##########
@@ -232,6 +232,13 @@ private MavenExecutionResult doExecute(
MavenExecutionRequest request, MavenSess
return addExceptionToResult( result, e );
}
+ for ( WorkspaceReader workspaceReader : getProjectScopedExtensions(
session.getProjects(),
+
WorkspaceReader.class ) )
+ {
+ repoSession.setWorkspaceReader(
ChainedWorkspaceReader.newInstance( repoSession.getWorkspaceReader(),
+
workspaceReader ) );
+ }
+
WorkspaceReader reactorWorkspace;
Review comment:
The `ChainedWorkspaceReader` has a constructor taking an array of
WorkspaceReader. I think it would make sense to use it instead of chaining
them one by one.
Btw, I think this also applies to the original call a few lines below:
```
repoSession.setWorkspaceReader( ChainedWorkspaceReader.newInstance(
reactorWorkspace,
repoSession.getWorkspaceReader() ) );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
